| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: XLog size reductions: Reduced XLog record header size for PG17 |
| Date: | 2023-07-03 11:08:31 |
| Message-ID: | CAEze2Wh2e57adcGXWJLo4hRQY-__CmWwaaSbUf9PGGOX5ESrmQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 30 Jun 2023 at 17:36, Matthias van de Meent
<boekewurm+postgres(at)gmail(dot)com> wrote:
>
> Hi,
>
> The attached v2 patchset contains some small fixes for the failing
> cfbot 32-bit tests - at least locally it does so.
>
> I'd overlooked one remaining use of MAXALIGN64() in xlog.c in the last
> patch of the set, which has now been updated to XLP_ALIGN as well.
> Additionally, XLP_ALIGN has been updated to use TYPEALIGN64 instead of
> TYPEALIGN so that we don't lose bits of the aligned value in 32-bit
> systems.
Apparently there was some usage of MAXALIGN() in xlogreader that I'd
missed, and which only shows up in TAP tests. In v3 I've fixed that,
together with some improved early detection of invalid record headers.
Kind regards,
Matthias van de Meent
Neon (https://neon.tech/)
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0005-Stop-the-logging-of-XIDs-in-records-where-the-XID.patch | application/octet-stream | 10.4 KB |
| v3-0001-Reduce-overhead-of-small-block-data-in-xlog-recor.patch | application/octet-stream | 10.9 KB |
| v3-0002-Replace-accesses-to-rmgr-s-XLogRecord-info-bit-ac.patch | application/octet-stream | 44.3 KB |
| v3-0003-Rename-rmgr_identify-info-bits-argument-to-rmgrin.patch | application/octet-stream | 21.6 KB |
| v3-0004-Move-rmgr-info-bits-into-their-own-field-in-the-x.patch | application/octet-stream | 26.1 KB |
| v3-0006-Reformat-the-XLog-record-header.patch | application/octet-stream | 44.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2023-07-03 11:19:40 | Re: pg_decode_message vs skip_empty_xacts and xact_wrote_changes |
| Previous Message | Ashutosh Bapat | 2023-07-03 10:30:29 | logicalrep_message_type throws an error |