Re: Reducing relcache memory usage: deduping index shapes

On Wed, 14 Oct 2026 at 09:28, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Tue, 13 Oct 2026 at 07:22, Matthias van de Meent
> <boekewurm+postgres(at)gmail(dot)com> wrote:
> > 0004/0005: Adjust for Proxy -> System /SystemCxt rename
>
> Here's a delta patch with various fixups for v4-0003

Thanks, attached is the adjusted patch series as v5, now again
including "rel.h: const-ify opclass-related fields of RelationData",
which I'd accidentally left out in v4. This should make CFBot happy
again.

[lots of review changes]
> * Various comment adjustments.

Applied, thanks!

> I spent some time running this under Valgrind, accessing the memory of
> a chunk made by SystemContextAlloc() and another after doing
> SystemContextRealloc() on a chunk. Valgrind is correctly giving me
> warnings when I access the byte before the pointer and when I access
> the sentinel byte manually. I don't see any warnings when I access
> bytes that are valid to access.
>
> I'm not aware of any other issues.

Thanks for the review!

Kind regards,

Matthias van de Meent
Databricks (https://www.databricks.com)