Re: Infinite Interval

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Joseph Koshakow <koshy44(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Infinite Interval
Date: 2023-11-09 07:15:01
Message-ID: CAExHW5vn6iKe_9XLAf+yqz0tnVHeDXvoBg45Ybqd9n-mDByEFQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 8, 2023 at 5:32 PM Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>
> On Wed, 8 Nov 2023 at 06:56, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> >
> > > On Tue, 7 Nov 2023 at 14:33, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> > >
> > > Ah, Windows Server didn't like that. Trying again with "INT64CONST(0)"
> > > instead of just "0" in interval_um().
> > >
> > I found this:
> > https://developercommunity.visualstudio.com/t/please-implement-integer-overflow-detection/409051
> > maybe related.
>
> Hmm, actually, this has revealed a bug in our 64-bit integer
> subtraction code, on platforms that don't have builtins or 128-bit
> integer support. I have created a new thread for that, since it's
> nothing to do with this patch.

Just to test whether that bug fix also fixes the failure seen with
this patchset, I am attaching the patchset including the patch with
the fix.

0001 - fix in other thread
0002 and 0003 are 0001 and 0002 in the previous patch set.

--
Best Wishes,
Ashutosh Bapat

Attachment Content-Type Size
0002-Avoid-integer-overflow-hazard-in-interval_t-20231109.patch text/x-patch 2.7 KB
0001-Fix-integer-overflow-in-pg_sub_s64_overflow-20231109.patch text/x-patch 2.1 KB
0003-Support-infinity-in-the-interval-data-type-20231109.patch text/x-patch 163.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2023-11-09 07:19:06 Re: make pg_ctl more friendly
Previous Message Ashutosh Bapat 2023-11-09 07:11:49 Re: RFC: Logging plan of the running query