| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | assam258(at)gmail(dot)com, Amit Langote <amitlangote09(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Ajay Pal <ajay(dot)pal(dot)k(at)gmail(dot)com>, Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SQL Property Graph Queries (SQL/PGQ) |
| Date: | 2026-02-25 06:40:55 |
| Message-ID: | CAExHW5vNZqCXuemXVL+nDDYkBeqJXdM3s=M3PWnymL6xqeB2WA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 19, 2026 at 3:01 PM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
>
> I am actually wondering whether the comment in parserOpenPropGraph()
> is required. In case we want to keep it, the attached patch has a typo
> fix. It also has some more improvements.
>
> >
> > Also, see this patch:
> >
> > https://www.postgresql.org/message-id/6d3fef19-a420-4e11-8235-8ea534bf2080%40eisentraut.org
> >
> > If this is accepted, it would make the change in the patch here even
> > smaller.
>
> +1. I think we should commit this, rebase SQL/PGQ patches and then
> apply this change.
Thanks for committing those patches. Here's a patchset rebased on top
of these commits.
0001 is the same as earlier 0001, but with a conflict in
pg_overexplain.sql/.out resolved. It needs 0002 so that a property
graph can be used in the GRAPH_TABLE clause.
0002 is your patch to add parserOpenPropGraph() with the typo and
comment fixed as mentioned above. It should be squashed into 0001 in
the next patchset.
--
Best Wishes,
Ashutosh Bapat
| Attachment | Content-Type | Size |
|---|---|---|
| v20260225-0002-Sort-out-RELKIND_PROPGRAPH-table_open.patch | text/x-patch | 5.8 KB |
| v20260225-0001-WIP-SQL-Property-Graph-Queries-SQL-PGQ.patch | text/x-patch | 698.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2026-02-25 06:43:49 | Re: amcheck: fix bug of missing corruption in allequalimage validation |
| Previous Message | Richard Guo | 2026-02-25 06:35:05 | Re: Consider low startup cost in add_partial_path |