Re: Infinite Interval

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Joseph Koshakow <koshy44(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Infinite Interval
Date: 2023-06-27 11:13:41
Message-ID: CAExHW5uWY+aqh5vcZD1dR6aH9iU_EZRxWeOhut3wRr_DhMtjKA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fixed assertion in time_mi_time(). It needed to assert that the result
is FINITE but it was doing the other way round and that triggered some
failures in cfbot.

On Fri, Jun 23, 2023 at 1:13 PM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
> Resending with .patch at the end in case cfbot needs that too.
>
> On Fri, Jun 23, 2023 at 12:57 PM Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> >
> > Looks like cfbot didn't like the names of these patches. It tried to
> > apply v20-0003 first and that failed. Attached patches with names in
> > sequential order. Let's see if that makes cfbot happy.
> >
> > On Thu, Apr 13, 2023 at 12:05 AM Joseph Koshakow <koshy44(at)gmail(dot)com> wrote:
> > >
> > >
> > >
> > > On Wed, Apr 12, 2023 at 9:11 AM Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> > >
> > > > I modified this to WHERE isfinite(t.f1) or isfinite(d.f1). The output
> > > > contains a lot of additions with infinity::interval but that might be
> > > > ok. No errors.
> > >
> > > Attached is a patch with this testing change.
> > >
> > > Thanks,
> > > Joe Koshakow
> >
> >
> >
> > --
> > Best Wishes,
> > Ashutosh Bapat
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat

--
Best Wishes,
Ashutosh Bapat

Attachment Content-Type Size
0002-Check-for-overflow-in-make_interval-20230627.patch text/x-patch 5.0 KB
0001-Move-integer-helper-function-to-int.h-20230627.patch text/x-patch 3.3 KB
0003-Add-infinite-interval-values-20230627.patch text/x-patch 96.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2023-06-27 11:17:16 Re: Assert !bms_overlap(joinrel->relids, required_outer)
Previous Message Amit Kapila 2023-06-27 10:50:56 Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication