Re: Use correct type for catalog_xmin

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use correct type for catalog_xmin
Date: 2026-06-05 11:52:35
Message-ID: CAExHW5tq_81=gih4hzPdEdDGqbQB8kVTXq3woxP5CEUqY5C98Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 5, 2026 at 3:33 PM Imran Zaheer <imran(dot)zhir(at)gmail(dot)com> wrote:
>
> Hi
>
> In commit 85c17f6, the variable old_catalog_xmin is using the type
> XLogRecPtr, even though data.catalog_xmin is a TransactionId.
>
> Attached patch fixes this by using TransactionId instead

Yes. Looks like a copy-pasto in 85c17f612af7b9c47a9828805686f0dd2433cdf1.

Patch LGTM.

--
Best Wishes,
Ashutosh Bapat

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2026-06-05 11:58:11 Re: Deadlock detector fails to activate on a hot standby replica
Previous Message Xuneng Zhou 2026-06-05 11:45:20 Re: Fix race in ReplicationSlotRelease for ephemeral slots