| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Small miscellaneous fixes |
| Date: | 2022-09-30 00:08:02 |
| Message-ID: | CAEudQArCDQQiPiFR16=yu9k5s2tp4tgEe1U1ZbkW4ofx81AWWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi.
There are assorted fixes to the head branch.
1. Avoid useless reassigning var _logsegno
(src/backend/access/transam/xlog.c)
Commit 7d70809
<https://github.com/postgres/postgres/commit/7d708093b7400327658a30d1aa1d5e284d37622c>
left a little oversight.
XLByteToPrevSeg and XLByteToSeg are macros, and both assign _logsegno.
So, the first assignment is lost and is useless.
2. Avoid retesting log_min_duration (src/backend/commands/analyze.c)
The log_min_duration has already been tested before and the second test
can be safely removed.
3. Avoid useless var declaration record (src/backend/utils/misc/guc.c)
The var record is never really used.
4. Fix declaration volatile signal var (src/bin/pgbench/pgbench.c)
Like how to commit 5ac9e86
<https://github.com/postgres/postgres/commit/5ac9e869191148741539e626b84ba7e77dc71670>,
this is a similar case.
regards,
Ranier Vilela
| Attachment | Content-Type | Size |
|---|---|---|
| avoid_useless_reassign_lgosegno.patch | application/octet-stream | 437 bytes |
| avoid_useless_retesting_log_min_duration.patch | application/octet-stream | 418 bytes |
| avoid_useless_var_record.patch | application/octet-stream | 625 bytes |
| fix_declaration_volatile_signal_var.patch | application/octet-stream | 484 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-09-30 00:12:56 | Re: making relfilenodes 56 bits |
| Previous Message | Peter Geoghegan | 2022-09-30 00:06:32 | Re: disfavoring unparameterized nested loops |