Re: Fix out-of-bounds in the function GetCommandTagName

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix out-of-bounds in the function GetCommandTagName
Date: 2024-04-15 11:35:55
Message-ID: CAEudQAr9ZtX=A0NmDGvW2P1MhrOB3UrrAd3VMz3sNtGjxhLpRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em dom., 14 de abr. de 2024 às 23:12, David Rowley <dgrowleyml(at)gmail(dot)com>
escreveu:

> On Mon, 15 Apr 2024 at 12:12, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> >
> > Em dom., 14 de abr. de 2024 às 20:38, David Rowley <dgrowleyml(at)gmail(dot)com>
> escreveu:
> >> You seem to have forgotten to attach it, but my comments above were
> >> written with the assumption that the patch is what I've attached here.
> >
> > Yes, I actually forgot.
> >
> > +1 for your patch.
>
> I've added a CF entry under your name for this:
> https://commitfest.postgresql.org/48/4927/

Thank you.

>
>
> If it was code new to PG17 I'd be inclined to go ahead with it now,
> but it does not seem to align with making the release mode stable.t
> I'd bet others will feel differently about that. Delaying seems a
> better default choice at least.
>
I agree. Although I initially thought it was a live bug, that's actually
not the case.
In fact, this is a refactoring.

best regards,
Ranier Vilela

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2024-04-15 11:43:34 Re: Fix possible dereference null pointer (src/backend/replication/logical/reorderbuffer.c)
Previous Message Andrew Dunstan 2024-04-15 10:35:46 Re: HEAD build error on Fedora 39