Re: Avoid overhead open-close indexes (catalog updates)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Avoid overhead open-close indexes (catalog updates)
Date: 2022-11-16 11:33:58
Message-ID: CAEudQApe93CV6XJPqzreM8ybsSEWp-JDahdsSYVT+jFUOta5zA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em qua., 16 de nov. de 2022 às 04:23, Michael Paquier <michael(at)paquier(dot)xyz>
escreveu:

> On Wed, Nov 16, 2022 at 06:58:01AM +0900, Michael Paquier wrote:
> > This one has been left out on purpose. I was tempting to use
> > WithInfo() with a CatalogIndexState opened optionally but I got the
> > impression that it makes the code a bit harder to follow and
> > AddRoleMems() is already complex on its own. Most DDL patterns
> > working on role would involve one role. More roles could be added of
> > course in one shot, but the extra logic complexity did not look that
> > appealing to me especially as some role updates are skipped.
>
> I have worked more on that today, and applied all that after splitting
> the whole in three commits in total as different areas were touched.
> It looks like we are good for this thread, then.
>
Thanks Michael.

>
> I have spotted more optimizations possible, particularly for operator
> classes, but that could happen later.
>
Good to know.

regards,
Ranier Vilela

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-11-16 11:44:02 Re: ExecRTCheckPerms() and many prunable partitions
Previous Message vignesh C 2022-11-16 11:24:34 Re: PGDOCS - Logical replication GUCs - added some xrefs