Re: Standardize type of variable when extending Buffers

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, gurjeet(at)singh(dot)im, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Standardize type of variable when extending Buffers
Date: 2023-09-19 11:29:51
Message-ID: CAEudQApEGA6U2MButpTwGTK9fS84yy9JDjPP8d=TX=sdJaPnDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em ter., 19 de set. de 2023 às 05:07, Peter Eisentraut <peter(at)eisentraut(dot)org>
escreveu:

> On 10.07.23 13:08, Ranier Vilela wrote:
> >
> > Em seg., 10 de jul. de 2023 às 03:27, Kyotaro Horiguchi
> > <horikyota(dot)ntt(at)gmail(dot)com <mailto:horikyota(dot)ntt(at)gmail(dot)com>> escreveu:
> >
> > At Fri, 7 Jul 2023 11:29:16 -0700, Gurjeet Singh <gurjeet(at)singh(dot)im
> > <mailto:gurjeet(at)singh(dot)im>> wrote in
> > > On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com
> > <mailto:ranier(dot)vf(at)gmail(dot)com>> wrote:
> > > >
> > > > Hi,
> > > >
> > > > This has already been discussed in [1].
> > > > But I thought it best to start a new thread.
> > > >
> > > > The commit 31966b1 introduced the infrastructure to extend
> > > > buffers.
> > > > But the patch mixed types with int and uint32.
> > > > The correct type of the variable counter is uint32.
> > > >
> > > > Fix by standardizing the int type to uint32.
> > > >
> > > > patch attached.
> > >
> > > LGTM.
> >
> > LGTM, too.
> >
> > Thanks Gurjeet and Kyotaro, for taking a look.
>
> committed
>
Thank you Peter.

best regards,
Ranier Vilela

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2023-09-19 11:56:43 Re: remaining sql/json patches
Previous Message Dean Rasheed 2023-09-19 11:14:20 Re: Infinite Interval