Fix incorrect const qualification for tbm_add_tuples() and itemptr_to_uint64()

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Fix incorrect const qualification for tbm_add_tuples() and itemptr_to_uint64()
Date: 2025-10-29 03:11:05
Message-ID: CAEoWx2m2E0xE8Kvbkv31ULh_E+5zph-WA_bEdv3UR9CLhw+3vg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Hackers,

I noticed a wrong const qualification:
```
void
tbm_add_tuples(TIDBitmap *tbm, const ItemPointer tids, int ntids,
bool recheck)
```

This "const" only protects "tids" itself from updating, which is
meaningless. I believe the real intention should be protecting the content
"tids" pointing to from updating.

This behavior can be easily proved by the compiler. If we add a line of
fake code in the function:
```
tids[0].ip_posid = 0;
```

With current "const ItemPointer tids", the compiler won't report any
problem. If we change to "const ItemPointerData *tids", the compiler will
raise an error due to the assignment to read-only variable.

I searched over the source tree, and found only one more occurrence in
itemptr_to_uint64(), so I fixed it as well.

Also, as I am touching tbm_add_tuples(), I did a tiny change that moved the
loop variable "i" into "for". Peter Eisentraut just did the same change in
formatting.c [1].

[1]
https://git.postgresql.org/cgit/postgresql.git/commit/?id=03fbb0814c5015ab79e670ab97bb6a3349269e4b

Best regards,
Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
https://www.highgo.com/

Attachment Content-Type Size
v1-0001-Fix-incorrect-const-qualification-for-tbm_add_tup.patch application/octet-stream 2.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-10-29 03:42:42 Remove meaningless const qualifier from ginCompressPostingList()
Previous Message wenhui qiu 2025-10-29 03:10:55 Re: another autovacuum scheduling thread