Re: pg_serial early wraparound

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <munro(at)ip9(dot)org>
Subject: Re: pg_serial early wraparound
Date: 2017-06-28 01:11:29
Message-ID: CAEepm=2aLSaNhhHbkBvgbJGDDkQqOqLoV8tngpuBWHZL2yYTvw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Sat, Mar 25, 2017 at 7:27 AM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> On Sat, Mar 25, 2017 at 3:11 AM, Anastasia Lubennikova
> <lubennikovaav(at)gmail(dot)com> wrote:
>> You claim that SLRUs now support five digit segment name, while in slru.h
>> at current master I see the following:
>>
>> * Note: slru.c currently assumes that segment file names will be four hex
>> * digits. This sets a lower bound on the segment size (64K transactions
>> * for 32-bit TransactionIds).
>> */

I've now complained about that comment in a separate thread.

> It's not urgent, it's just cleanup work, so I've now moved it to the
> next commitfest. I will try to figure out a new way to demonstrate
> that it works correctly without having to ask a review[er] to disable
> any assertions. Thanks again.

Here's a rebased batch.

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
ssi-slru-wraparound-v2.patch application/octet-stream 3.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2017-06-28 02:07:43 Re: Pluggable storage
Previous Message Thomas Munro 2017-06-28 00:58:37 Re: WIP: [[Parallel] Shared] Hash