| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Antonin Houska <ah(at)cybertec(dot)at> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Suspicious call of initial_cost_hashjoin() |
| Date: | 2018-03-02 10:01:33 |
| Message-ID: | CAEepm=23tCnUwMzYDpYJQUOQZfgB3nGRVnAif=vLeFYTg-XLVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 2, 2018 at 9:06 PM, Antonin Houska <ah(at)cybertec(dot)at> wrote:
> David Steele <david(at)pgmasters(dot)net> wrote:
>> Does this look right to you?
>
> Yes, this is what I meant. The patch applies cleanly and the code compiles
> well.
>
>> If so, can you sign up as a reviewer and mark it Ready for Committer?
>
> Done.
Thanks.
> Actually I think it'd be nice if the "parallel_hash" argument was mentioned in
> the header comment of initial_cost_hashjoin() function, but not sure this is
> worth returning the patch to the author.
Done.
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-costing-of-parallel-hash-joins-v2.patch | application/octet-stream | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2018-03-02 10:02:52 | Re: 2018-03 Commitfest Summary (Andres #1) |
| Previous Message | Fabien COELHO | 2018-03-02 09:47:01 | Re: 2018-03 Commitfest Summary (Andres #1) |