Re: Making tab-complete.c easier to maintain

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Making tab-complete.c easier to maintain
Date: 2015-10-19 04:12:29
Message-ID: CAEepm=1ns0rbo+xun_j6_PwDT6zmEPuNggy=Vaie-3peF2C44Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 19, 2015 at 4:58 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> On Sun, Oct 18, 2015 at 5:31 PM, Thomas Munro
> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>>
>> Hi
>>
>> Here is a new version merging recent changes.
>
>
> For reasons I do not understand, "SET work_mem " does not complete with
> "TO".
>
> But if I change:
>
> else if (Matches2("SET", MatchAny))
>
> to:
>
> else if (TailMatches2("SET", MatchAny))
>
> Then it does.

Thanks for taking a look at this! The word count returned by
get_previous_words was incorrect. Here is a corrected version.

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
tab-complete-macrology-v5.patch.gz application/x-gzip 19.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kouhei Kaigai 2015-10-19 04:17:56 Re: Foreign join pushdown vs EvalPlanQual
Previous Message Jeff Janes 2015-10-19 03:58:00 Re: Making tab-complete.c easier to maintain