| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Making tab-complete.c easier to maintain |
| Date: | 2015-10-23 19:01:28 |
| Message-ID: | CAEepm=1Oaq+L_6KCZ5o_hNn-=T93_LiK=_T1C9DcPzgXs4H84g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 24, 2015 at 6:19 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> On Sun, Oct 18, 2015 at 9:12 PM, Thomas Munro
> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>> Thanks for taking a look at this! The word count returned by
>> get_previous_words was incorrect. Here is a corrected version.
>
> I haven't looked at v6 yet, but in v5:
>
> "set work_mem TO" completes to "NULL" not to "DEFAULT"
>
> line 2665 of the patched tab complete file,, should be "DEFAULT", not "NULL"
> as the completion string. Looks like a simple copy and paste error.
Indeed. Thanks. Fixed in the attached.
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| tab-complete-macrology-v7.patch.gz | application/x-gzip | 19.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2015-10-23 19:49:07 | Re: Making tab-complete.c easier to maintain |
| Previous Message | Robert Haas | 2015-10-23 18:33:34 | Re: [DESIGN] ParallelAppend |