| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Oskari Saarenmaa <os(at)ohmu(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
| Subject: | Re: pread() and pwrite() |
| Date: | 2018-11-03 11:03:06 |
| Message-ID: | CAEepm=0gKm3WvzUKkfynkc6TFJ3MrfmX7MBFi9nPvDd3gTapOw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Nov 3, 2018 at 2:07 AM Jesper Pedersen
<jesper(dot)pedersen(at)redhat(dot)com> wrote:
> This still applies, and passes make check-world.
>
> I wonder what the commit policy is on this, if the Windows part isn't
> included. I read Heikki's comment [1] as it would be ok to commit
> benefiting all platforms that has pread/pwrite.
Here's a patch to add Windows support by supplying
src/backend/port/win32/pread.c. Thoughts?
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-pread-pwrite-instead-of-lseek-read-write-v8.patch | application/octet-stream | 25.4 KB |
| 0002-Supply-pread-pwrite-implementations-for-Windows-v8.patch | application/octet-stream | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2018-11-03 12:00:46 | Re: pgbench -M option can be specified more than once |
| Previous Message | Fabien COELHO | 2018-11-03 11:01:01 | Re: Constraint documentation |