| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Subject: | TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity |
| Date: | 2017-11-29 07:58:25 |
| Message-ID: | CAEepm=0NvOGZ8B6GbQyQe2C_c2m3LKJ9w=8OMBaYRLgZ_Gw6Nw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
Andrew Gierth complained off-list that TupleDescCopy() doesn't clear
atthasdef. Yeah, that's an oversight. The function is new in commit
cc5f81366c36 and was written by me to support "flat" (pointer-free)
tuple descriptors for use in DSM. Following the example of
CreateTupleDescCopy() I think it should also clear attnotnull and
attidentity. Please see attached.
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix-TupleDescCopy-v1.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-11-29 08:09:34 | Expression based grouping equality implementation |
| Previous Message | Michael Paquier | 2017-11-29 06:03:21 | Re: [HACKERS] A design for amcheck heapam verification |