Re: Supporting MERGE on updatable views

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Supporting MERGE on updatable views
Date: 2023-10-30 09:33:53
Message-ID: CAEZATCXq=UYUwCNVF1Ysq2Urg5WG9zRZTEc-R0ecR_ya9o-ZEA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 29 Oct 2023 at 17:17, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>
> On Sat, 28 Oct 2023 at 09:35, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> >
> > Do we need to add <<command>MERGE</command> for the following sentence?
> >
> We don't want to include MERGE in that sentence, because MERGE isn't
> supported on views or tables with rules, but I guess we could add
> another sentence after that one, to make that clear.
>

Here's an updated patch doing that, plus another couple of minor
updates to that page.

I also noticed that the code to detect rules ought to ignore disabled
rules, so I've updated it to do so, and added a new regression test to
cover that case.

Arguably that's a pre-existing bug, so the fix could be extracted and
applied separately, but I'm not sure that it's worth the effort.

Regards,
Dean

Attachment Content-Type Size
support-merge-into-view-v10.patch text/x-patch 123.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2023-10-30 09:35:09 Re: pg_upgrade and logical replication
Previous Message Bharath Rupireddy 2023-10-30 09:25:01 Re: A recent message added to pg_upgade