From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Supporting MERGE on updatable views |
Date: | 2023-02-07 10:03:46 |
Message-ID: | CAEZATCXYUqWyDe=iy-kZRV=3APBqX0UJgv5oQ84WjVfSncmkRQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, 21 Jan 2023 at 11:03, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>
> Rebased version, following 5d29d525ff.
>
Updated version attached.
This needed a little extra tweaking to work following the change to
make Vars outer-join aware, so it's worth checking that I understood
that properly -- when merging into a trigger-updatable view, the
whole-row Var added to the targetlist by the rewriter is nullable by
the join added by transform_MERGE_to_join().
The make-Vars-outer-join-aware patch has possibly made this patch's
change to preprocess_targetlist() unnecessary, but I left it in just
in case, even though I can no longer trigger that failure mode. It
feels safer, and more consistent with the code later on in that
function.
Regards,
Dean
Attachment | Content-Type | Size |
---|---|---|
support-merge-into-view-v5.patch | text/x-patch | 122.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Aleksander Alekseev | 2023-02-07 10:05:45 | Re: Pluggable toaster |
Previous Message | Yugo NAGATA | 2023-02-07 09:56:57 | Re: make_ctags: use -I option to ignore pg_node_attr macro |