Re: Improving and extending int128.h to more of numeric.c

On Mon, 14 Jul 2025 at 11:22, John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>
> (Looking at v3) The new test module runs 10 million rather than a
> billion iterations. That still takes 1.2s (after 0005), which seems
> excessive for regular buildfarm testing. It seems like we could get by
> with fewer than that, by using the time of day for the PRNG seed
> (which would also need to be logged on error).

Thanks for looking!

I have reduced the number of iterations and changed it to use the
current time for the PRNG seed. I don't see much value in logging the
seed though, since we already log the inputs that cause any failure.

> > 0005 is the main patch.
> >
> I haven't looked too closely, but wanted to point out:
>
> warning: format ‘%lX’ expects argument of type ‘long unsigned int’,
> but argument 4 has type ‘int32’ {aka ‘int’} [-Wformat=]
>
> ...

Ah yes, thanks for pointing that out.

(The cfbot reports the same warnings, but you have to scroll through a
lot of output to see them. It would be nice if the commitfest app had
an indicator to show if there were any compiler warnings.)

v4 attached.

Regards,
Dean