| From: | Paul Guo <pguo(at)pivotal(dot)io> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jimmy Yih <jyih(at)pivotal(dot)io>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Subject: | Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) |
| Date: | 2019-07-15 08:52:14 |
| Message-ID: | CAEET0ZF+Pjm7t9vafnpSvh+g_Jeun7UNs4rHrUxV2d9bFPzttQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 10, 2019 at 3:28 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Jul 09, 2019 at 10:48:49PM +0800, Paul Guo wrote:
> > Yes, the patches changed Makefile so that pg_rewind and pg_basebackup
> could
> > use some common code, but for Windows build, I'm not sure where are those
> > window build files. Does anyone know about that? Thanks.
>
> The VS scripts are located in src/tools/msvc/. You will likely need
> to tweak things like $frontend_extraincludes or variables in the same
> area for this patch (please see Mkvcbuild.pm).
>
Thanks. Both Mkvcbuild.pm and pg_rewind/Makefile are modified to make
Windows build pass in a
local environment (Hopefully this passes the CI testing), also now
pg_rewind/Makefile does not
create soft link for backup_common.h anymore. Instead -I is used to specify
the header directory.
I also noticed that doc change is needed so modified documents for the two
new options accordingly.
Please see the attached new patches.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0002-Add-option-to-write-recovery-configuration-inform.patch | application/octet-stream | 3.3 KB |
| v4-0003-Ensure-target-clean-shutdown-at-the-beginning-of-.patch | application/octet-stream | 5.9 KB |
| v4-0001-Extact-common-functions-from-pg_basebackup-into-s.patch | application/octet-stream | 17.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2019-07-15 10:06:37 | Re: Option to dump foreign data in pg_dump |
| Previous Message | Konstantin Knizhnik | 2019-07-15 07:09:42 | Re: Built-in connection pooler |