From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Microvacuum support for Hash Index |
Date: | 2016-11-02 05:38:19 |
Message-ID: | CAE9k0P=9ftuLnHWvhL+NKHD+tT+yPqi+G4ec4kxEiwEOF1tyrQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
> While replaying the delete/vacuum record on standby, it can conflict
> with some already running queries. Basically the replay can remove
> some row which can be visible on standby. You need to resolve
> conflicts similar to what we do in btree delete records (refer
> btree_xlog_delete).
Agreed. Thanks for putting this point. I have taken care of it in the
attached v2 patch.
> + /*
> + * Write-lock the meta page so that we can decrement
> + * tuple count.
> + */
> + _hash_chgbufaccess(rel, metabuf, HASH_NOLOCK, HASH_WRITE);
> +
> + _hash_vacuum_one_page(rel, metabuf, buf, bucket_buf,
> + (buf == bucket_buf) ? true : false);
> +
> + _hash_chgbufaccess(rel, metabuf, HASH_READ, HASH_NOLOCK);
>
> It seems here meta page lock is acquired for duration more than
> required and also it is not required when there are no deletable items
> on page. You can take the metapage lock before decrementing the count.
Ok. Corrected. Please refer to the attached v2 patch.
> Spurious space. There are some other similar spurious white space
> changes in patch, remove them as well.
Corrected. Please refer attached v2 patch.
Attachment | Content-Type | Size |
---|---|---|
microvacuum_hash_index_v2.patch | text/x-patch | 24.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-11-02 06:34:20 | Re: sequences and pg_upgrade |
Previous Message | Michael Paquier | 2016-11-02 04:53:55 | Re: WAL consistency check facility |