| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve geometric types |
| Date: | 2018-08-01 11:40:00 |
| Message-ID: | CAE2gYzzRs+4NpPnPy+x=+xe_KDWiOZaqdSiM5qXbYsCP=R+HCg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Ah, so there's an assumption that NaNs are handled earlier and never reach
> this place? That's probably a safe assumption. I haven't thought about that,
> it simply seemed suspicious that the code mixes direct comparisons and
> float8_mi() calls.
The comparison functions handle NaNs. The arithmetic functions handle
returning error on underflow, overflow and division by zero. I
assumed we want to return error on those in any case, but we don't
want to handle NaNs at every place.
> Not sure, I'll leave that up to you. I don't mind doing it in a separate
> patch (I'd probably prefer that over mixing it into unrelated patch).
It is attached separately.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-geo-debug-v00.patch | application/octet-stream | 2.8 KB |
| 0002-geo-float-v14.patch | application/octet-stream | 82.5 KB |
| 0003-line-fixes-v13.patch | application/octet-stream | 12.9 KB |
| 0004-geo-tests-v09.patch | application/octet-stream | 659.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Emre Hasegeli | 2018-08-01 11:44:03 | Re: [PATCH] Improve geometric types |
| Previous Message | Fabien COELHO | 2018-08-01 11:36:09 | Re: Doc patch: add RECURSIVE to bookindex |