|From:||Emre Hasegeli <emre(at)hasegeli(dot)com>|
|To:||Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>|
|Cc:||Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: [PATCH] Improve geometric types|
|Views:||Raw Message | Whole Thread | Download mbox|
> And this should be the last comment of mine on the patch set.
Thank you. The new versions of the patches are attached addressing
> By the way, I found that MAXDOUBLEWIDTH has two inconsistent
> definitions in formatting.c(500) and float.c(128). The definition
> in new float.h is according to float.c and it seems better to be
> untouched and it would be another issue.
The last version of the patch don't move these declarations to the header file.
> # The commit message of 0001 says that "using C11 hypot()" but it
> # is sine C99. I suppose we shold follow C99 at the time so I
> # suggest rewrite it in the next version if any.
> close_pl got a bug fix not only refactoring. I think it is
> recommended to separate bugs and improvements, but I'm fine with
> the current patch.
I split the refactoring to the first patch.
> You added sanity check "A==0 && B==0" (in Ax + By + C) in
> line_recv. I'm not sure the necessity of the check since it has
> been checked in line_in but anyway the comparisons seem to be
> typo(or thinko) of FPzero.
Tom Lane suggested  this one. I now made it use FPzero().
> dist_pl is changed to take the smaller distance of both ends of
> the segment. It seems absorbing error, so it might be better
> taking the mean of the two distances. If you have a firm reason
> for the change, it is better to be written there, or it might be
> better left alone.
I don't really, so I left that part out.
|Next Message||Daniel Gustafsson||2017-10-02 09:53:16||Re: [PATCH] Assert that the correct locks are held when calling PageGetLSN()|
|Previous Message||Daniel Gustafsson||2017-10-02 09:36:27||Re: Patch: Write Amplification Reduction Method (WARM)|