Re: [PATCH] Improve geometric types

From: Emre Hasegeli <emre(at)hasegeli(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Improve geometric types
Date: 2017-09-27 15:44:52
Message-ID: CAE2gYzz2=335XEMHK-neNo=HgGskkPHQxUXkh8yDNsZAnCB5Bg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

The new versions of the patches are attached addressing your comments.

> C++ surely make just static functions inlined but I'm not sure C
> compiler does that.

Thank you for your explanation. I marked the mentioned functions "inline".

> So we should be safe to have a buffer with 26 byte length and 500
> bytes will apparently too large and even 128 will be too loose in
> most cases. So how about something like the following?
>
> #define MINDOUBLEWIDTH 32

I left this part out for now. We can improve it separately.

Attachment Content-Type Size
0001-geo-funcs-v03.patch application/octet-stream 75.4 KB
0002-float-header-v07.patch application/octet-stream 84.2 KB
0003-geo-float-v04.patch application/octet-stream 99.9 KB
0004-line-fixes-v03.patch application/octet-stream 10.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Emre Hasegeli 2017-09-27 15:45:04 Re: [PATCH] Improve geometric types
Previous Message Robert Haas 2017-09-27 15:34:22 Re: Multicolumn hash indexes