| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgres_fdw: Handle boolean comparison predicates |
| Date: | 2021-05-31 16:51:57 |
| Message-ID: | CAE2gYzysXxtGgpJKBnSgdtocbZj0JbEHP1KUH=y2bKhbz6uOHA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Please add this patch to the commitfest so that it's not forgotten. It
> will be considered as a new feature so will be considered for commit
> after the next commitfest.
I did [1]. You can add yourself as a reviewer.
> I don't understand why we need to complicate the expressions when
> sending those to the foreign nodes. Why do we want to send
> (NOT xyz OR xyz IS NULL) and not as just (xyz IS FALSE).
> The latter is much more readable and less error-prone. That true for
> all the BooleanTest deparsing.
= true/false conditions are normalised. I thought similar behaviour
would be expected here.
> +EXPLAIN (VERBOSE, COSTS OFF) SELECT * FROM ft1 t1 WHERE (c1 = 100) IS
> TRUE; -- BooleanTest
>
> Also test a boolean column?
There isn't a boolean column on the test table currently.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2021-05-31 18:50:57 | Re: proposal: enhancing plpgsql debug API - returns text value of variable content |
| Previous Message | Alexander Pyhalov | 2021-05-31 16:04:17 | Re: join pushdown and issue with foreign update |