| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BRIN range operator class |
| Date: | 2015-05-06 09:49:33 |
| Message-ID: | CAE2gYzwY8y1LfRk9MHc09XXLTPrqZnM8oJEqhgWfat8NV7OQZw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> After looking at 05 again, I don't like the "same as %" business.
> Creating a whole new class of exceptions is not my thing, particularly
> not in a regression test whose sole purpose is to look for exceptional
> (a.k.a. "wrong") cases. I would much rather define the opclasses for
> those two datatypes using the existing @> operators rather than create
> && operators for this purpose. We can add a note to the docs, "for
> historical reasons the brin opclass for datatype box/point uses the <@
> operator instead of &&", or something like that.
I worked around this by adding point <@ box operator as the overlap
strategy and removed additional && operators.
> AFAICS this is just some pretty small changes to patches 05 and 06.
> Will you please resubmit?
New series of patches are attached. Note that
brin-inclusion-v08-04-fix-brin-deform-tuple.patch is the one from you.
| Attachment | Content-Type | Size |
|---|---|---|
| brin-inclusion-v08-02-strategy-numbers.patch | application/octet-stream | 4.5 KB |
| brin-inclusion-v08-03-remove-assert-checking.patch | application/octet-stream | 4.2 KB |
| brin-inclusion-v08-04-fix-brin-deform-tuple.patch | application/octet-stream | 6.5 KB |
| brin-inclusion-v08-05-box-vs-point-operators.patch | application/octet-stream | 12.6 KB |
| brin-inclusion-v08-06-inclusion-opclasses.patch | application/octet-stream | 80.8 KB |
| brin-inclusion-v08-07-remove-minmax-amprocs.patch | application/octet-stream | 34.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Volker Aßmann | 2015-05-06 10:02:05 | Re: Disabling trust/ident authentication configure option |
| Previous Message | Emre Hasegeli | 2015-05-06 09:31:11 | Re: BRIN range operator class |