| From: | Soumyadeep Chakraborty <soumyadeep2007(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Don't codegen deform code for virtual tuples in expr eval for scan fetch |
| Date: | 2019-09-26 05:11:51 |
| Message-ID: | CAE-ML+9OKSN71+mHtfMD-L24oDp8dGTfaVjDU6U+j+FNAW5kRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Andres,
Thank you very much for reviewing my patch!
On Wed, Sep 25, 2019 at 1:02 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> IOW, wherever ExecComputeSlotInfo() is called, we should only actually
> push the expression step, when ExecComputeSlotInfo does not determine
> that a) the slot is virtual, b) and fixed (i.e. guaranteed to always be
> the same type of slot).
>
> Does that make sense?
That is a great suggestion and I totally agree. I have attached a patch
that achieves this.
--
Soumyadeep
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Skip-deform-expr-step-emission-for-virtual-tuples.patch | application/octet-stream | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Soumyadeep Chakraborty | 2019-09-26 05:12:10 | Re: Don't codegen deform code for virtual tuples in expr eval for scan fetch |
| Previous Message | Amit Langote | 2019-09-26 04:56:37 | Re: partition routing layering in nodeModifyTable.c |