Re: Ltree syntax improvement

From: Dmitry Belyavsky <beldmit(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Ltree syntax improvement
Date: 2019-07-11 17:49:41
Message-ID: CADqLbzKCh2e-nOyAtCX4GqW+HbwD4yX=wuOMMRFGtRYWgcnMeg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Thomas,

On Thu, Jul 11, 2019 at 11:20 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
wrote:

> On Wed, Jul 10, 2019 at 7:40 AM Dmitry Belyavsky <beldmit(at)gmail(dot)com>
> wrote:
> > [ltree_20190709.diff]
>
> Hi Dmitry,
>
> You need to update contrib/ltree_plpython/expected/ltree_plpython.out,
> otherwise check-world fails when built with Python support. The good
> news is that it looks like it fails because you fixed something!
> (Though I didn't check the details).
>
> CREATE FUNCTION test2() RETURNS ltree
> LANGUAGE plpythonu
> TRANSFORM FOR TYPE ltree
> AS $$
> return ['foo', 'bar', 'baz']
> $$;
> -- plpython to ltree is not yet implemented, so this will fail,
> -- because it will try to parse the Python list as an ltree input
> -- string.
> SELECT test2();
> -ERROR: syntax error at position 0
> -CONTEXT: while creating return value
> -PL/Python function "test2"
> + test2
> +-------------------------
> + "['foo', 'bar', 'baz']"
> +(1 row)
> +
>
>
See attached. I'm not familiar enough with python so I just removed the
failing tests.
If the main patch is accepted, the ltree_python extension should be
redesigned, I think...

--
SY, Dmitry Belyavsky

Attachment Content-Type Size
ltree_20190711.diff text/x-patch 79.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2019-07-11 17:51:23 Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.
Previous Message Peter Geoghegan 2019-07-11 17:42:55 Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.