| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Daniel Verite <daniel(at)manitou-mail(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Date: | 2017-02-06 19:50:18 |
| Message-ID: | CADkLM=fYJ=1rQbj=dCoMrFkVs=+6=cfmNSD8RRSL8-UxF40-Ew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 6, 2017 at 2:32 PM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>
> Do you think the TAP tests would benefit from having the input described
>> in a q(...) block rather than a string?
>>
>
> My 0.02€: Not really, so I would not bother. It breaks perl indentation
> and logic for a limited benefit. Maybe add comments if you feel that a test
> case is unclear.
>
> --
> Fabien.
Consolidated Fabien's TAP test additions with v7, in case anyone else wants
to be reviewing.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001.if_endif.v8.diff | text/plain | 29.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-02-06 19:53:44 | Re: LWLock optimization for multicore Power machines |
| Previous Message | Alexander Korotkov | 2017-02-06 19:44:24 | Re: LWLock optimization for multicore Power machines |