| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, Erik Rijkers <er(at)xs4all(dot)nl>, Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Date: | 2017-02-26 01:54:56 |
| Message-ID: | CADkLM=edWn9Kfj10BUAr4VTkLxAmkAc_u0_6AfjHTBC6phmhRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> Typo "unterminted".
>
Fixed.
> The \if within the \if false branch is not tallied properly? Am I missing
> something?
>
Nope, you found a bug. FIxed. Test-case added.
> I changed the paragraph to
>>
>
> Lines within false branches are parsed normally, however, any
>> completed
>> queries are not sent to the server, and any completed commands
>> other
>> than conditionals (<command>\if</command>,
>> <command>\elif</command>,
>> <command>\else</command>, <command>\endif</command>) are ignored.
>>
>
> I'm not sure about the ", however, " commas, but I'm sure that I do not
> know English punctuation rules:-)
>
Re-worded it again for shorter sentences. Re-mentioned that conditionals
are still checked for proper nesting.
* Changed comments to reflect that \if always evalutes <expr> even in a
false branch
* Changed \elif to first check if the command is in a proper \if block
before evaluating the expression. The invalid boolean message would mask
the bigger problem.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001.if_endif.v18.diff | text/plain | 32.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-02-26 03:09:00 | Re: WIP: Covering + unique indexes. |
| Previous Message | Amit Kapila | 2017-02-26 01:04:23 | Re: Enabling parallelism for queries coming from SQL or other PL functions |