Re: [PATCH] Improve performance of NOTIFY over many databases (v2)

From: Martijn van Oosterhout <kleptog(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Improve performance of NOTIFY over many databases (v2)
Date: 2019-09-11 14:07:17
Message-ID: CADWG95vnshiyHF5tKmeCD+k6fhQpRQJ3C6hKYqL78SO67CzivA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hoi Tom,

On Wed, 11 Sep 2019 at 00:18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

>
> I pushed 0001 after doing some hacking on it --- it was sloppy about
> datatypes, and about whether the invalid-entry value is 0 or -1,
> and it was just wrong about keeping the list in backendid order.
> (You can't conditionally skip looking for where to put the new
> entry, if you want to maintain the order. I thought about just
> defining the list as unordered, which would simplify joining the
> list initially, but that could get pretty cache-unfriendly when
> there are lots of entries.)
>
> 0002 is now going to need a rebase, so please do that.
>
>
Thanks for this, and good catch. Looks like I didn't test the first patch
by itself very well.

Here is the rebased second patch.

Thanks in advance,
--
Martijn van Oosterhout <kleptog(at)gmail(dot)com> http://svana.org/kleptog/

Attachment Content-Type Size
0002-Improve-performance-of-async-notifications.patch text/x-patch 13.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-09-11 14:25:07 Re: [patch]socket_timeout in interfaces/libpq
Previous Message Tom Lane 2019-09-11 13:54:52 Re: A problem presentaion about ECPG, DECLARE STATEMENT