| From: | Dave Cramer <davecramer(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2020-07-14 18:08:53 |
| Message-ID: | CADK3HHKaSs7V238eO5uanrEo_nnL+i2qeVDMaGtoDEpjNFZH2w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 14 Jul 2020 at 12:59, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> So I started looking through this seriously, and my first question
> is why do the docs and code keep saying that "base types" are sent
> in binary? Why not just "data"? Are there any cases where we
> don't use binary format, if the subscription requests it?
>
> If there's not a concrete reason to use that terminology,
> I'd rather flush it, because it seems confusing.
>
Well for some reason I thought there were some types that did not have send
and receive functions.
I've changed the docs to say data and the flag from binary_basetypes to
just binary
See attached.
Thanks,
Dave
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-binary-protocol-for-publications-and-subscriptio.patch | application/octet-stream | 47.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Floris Van Nee | 2020-07-14 18:18:50 | RE: Index Skip Scan (new UniqueKeys) |
| Previous Message | Anastasia Lubennikova | 2020-07-14 17:51:37 | Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits |