| From: | Dave Cramer <davecramer(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2020-07-06 13:35:36 |
| Message-ID: | CADK3HHKH5juHJKNAX4H6hda7BOWtnbuZV3rCvsc5tEAJBKCt8w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 6 Jul 2020 at 09:03, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 6 Jul 2020, at 14:58, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>
> > as far as rebase -i do what is advised here for squashing them. Just one
> patch now ?
>
> One patch per logical change, if there are two disjoint changes in the
> patchset
> where one builds on top of the other then multiple patches are of course
> fine.
> My personal rule-of-thumb is to split it the way I envision it committed.
>
At this point it is the result of 3 rebases. I guess I'll have to break it
up differently..
Thanks,
Dave
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2020-07-06 13:37:18 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |
| Previous Message | Fujii Masao | 2020-07-06 13:16:18 | Re: Is it useful to record whether plans are generic or custom? |