| From: | Dave Cramer <davecramer(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2020-07-07 00:16:50 |
| Message-ID: | CADK3HHK3Vpq=wuikKM0uCf+p9=1jPk3njw_JdmRMF+6wyp-+5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 6 Jul 2020 at 09:35, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>
>
> On Mon, 6 Jul 2020 at 09:03, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> > On 6 Jul 2020, at 14:58, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>>
>> > as far as rebase -i do what is advised here for squashing them. Just
>> one patch now ?
>>
>> One patch per logical change, if there are two disjoint changes in the
>> patchset
>> where one builds on top of the other then multiple patches are of course
>> fine.
>> My personal rule-of-thumb is to split it the way I envision it committed.
>>
>
> At this point it is the result of 3 rebases. I guess I'll have to break it
> up differently..
>
>
OK, rebased it down to 2 patches, attached.
> Thanks,
>
> Dave
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-binary-protocol-for-publications-and-subscriptio.patch | application/octet-stream | 38.6 KB |
| 0002-document-new-binary-option-for-CREATE-SUBSCRIPTION.patch | application/octet-stream | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-07-07 00:32:22 | Re: Multi-byte character case-folding |
| Previous Message | Alvaro Herrera | 2020-07-06 22:46:23 | Re: Multi-byte character case-folding |