Re: Transactions involving multiple postgres foreign servers

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Vinayak Pokale <vinpokale(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
Subject: Re: Transactions involving multiple postgres foreign servers
Date: 2017-02-15 06:11:02
Message-ID: CAD21AoDDj5THJjd9f+cOxEgTuM40P_XU-kTW1f1-vhfe8OmJsw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Mon, Feb 6, 2017 at 10:48 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Wed, Feb 1, 2017 at 8:25 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Mon, Jan 30, 2017 at 2:30 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>>> "txn" can be used for abbreviation of "Transaction", so for example
>>> pg_fdw_txn_resolver?
>>> I'm also fine to change the module and function name.
>>
>> If we're judging the relative clarity of various ways of abbreviating
>> the word "transaction", "txn" surely beats "x".
>>
>> To repeat my usual refrain, is there any merit to abbreviating at all?
>> Could we call it, say, "fdw_transaction_resolver" or
>> "fdw_transaction_manager"?
>>
>
> Almost modules in contrib are name with "pg_" prefix but I prefer
> "fdw_transcation_resolver" if we don't need "pg_" prefix.
>

Since previous patches conflict to current HEAD, attached latest
version patches.
Please review them.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
000_support_fdw_xact_v8.patch application/octet-stream 112.2 KB
001_pgfdw_support_atomic_commit_v8.patch application/octet-stream 42.7 KB
002_pg_fdw_resolver_contrib_v8.patch application/octet-stream 16.3 KB
003_regression_test_for_fdw_xact_v8.patch application/octet-stream 6.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-02-15 06:31:41 Re: [Bug fix] PQsendQuery occurs error when target_session_attrs is set to read-write
Previous Message Amit Kapila 2017-02-15 06:07:45 Re: parallelize queries containing subplans