Re: [PoC] Improve dead tuple storage for lazy vacuum

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum
Date: 2023-04-17 15:20:16
Message-ID: CAD21AoCw9RPvEtYQxLCT6jO6RXF0_j8d8M-b+jaLERa1aifeCQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 11, 2023 at 12:26 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Fri, Mar 10, 2023 at 11:30 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Fri, Mar 10, 2023 at 3:42 PM John Naylor
> > <john(dot)naylor(at)enterprisedb(dot)com> wrote:
> > >
> > > On Thu, Mar 9, 2023 at 1:51 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> > > > I've attached the new version patches. I merged improvements and fixes
> > > > I did in the v29 patch.
> > >
> > > I haven't yet had a chance to look at those closely, since I've had to devote time to other commitments. I remember I wasn't particularly impressed that v29-0008 mixed my requested name-casing changes with a bunch of other random things. Separating those out would be an obvious way to make it easier for me to look at, whenever I can get back to this. I need to look at the iteration changes as well, in addition to testing memory measurement (thanks for the new results, they look encouraging).
> >
> > Okay, I'll separate them again.
>
> Attached new patch series. In addition to separate them again, I've
> fixed a conflict with HEAD.
>

I've attached updated version patches to make cfbot happy. Also, I've
splitted fixup patches further(from 0007 except for 0016 and 0018) to
make reviews easy. These patches have the prefix radix tree, tidstore,
and vacuum, indicating the part it changes. 0016 patch is to change
DSA so that we can specify both the initial and max segment size and
0017 makes use of it in vacuumparallel.c I'm still researching a
better solution for memory limitation but it's the best solution for
me for now.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v32-0015-vacuum-Miscellaneous-updates.patch application/octet-stream 4.9 KB
v32-0016-Make-initial-and-maximum-DSA-segment-size-config.patch application/octet-stream 9.6 KB
v32-0014-tidstore-Miscellaneous-updates.patch application/octet-stream 7.3 KB
v32-0018-Revert-building-benchmark-module-for-CI.patch application/octet-stream 694 bytes
v32-0017-tidstore-vacuum-Specify-the-init-and-max-DSA-seg.patch application/octet-stream 4.8 KB
v32-0010-radix-tree-fix-radix-tree-test-code.patch application/octet-stream 6.8 KB
v32-0011-tidstore-vacuum-Use-camel-case-for-TidStore-APIs.patch application/octet-stream 25.0 KB
v32-0012-tidstore-Use-concept-of-off_upper-and-off_lower.patch application/octet-stream 12.6 KB
v32-0009-radix-tree-Review-tree-iteration-code.patch application/octet-stream 13.9 KB
v32-0013-tidstore-Embed-output-offsets-in-TidStoreIterRes.patch application/octet-stream 1.9 KB
v32-0008-radix-tree-remove-resolved-TODO.patch application/octet-stream 706 bytes
v32-0007-radix-tree-rename-RT_EXTEND-and-RT_SET_EXTEND-to.patch application/octet-stream 2.6 KB
v32-0006-Use-TIDStore-for-storing-dead-tuple-TID-during-l.patch application/octet-stream 48.3 KB
v32-0005-Tool-for-measuring-radix-tree-and-tidstore-perfo.patch application/octet-stream 24.7 KB
v32-0004-Add-TIDStore-to-store-sets-of-TIDs-ItemPointerDa.patch application/octet-stream 36.0 KB
v32-0002-Move-some-bitmap-logic-out-of-bitmapset.c.patch application/octet-stream 6.0 KB
v32-0001-Introduce-helper-SIMD-functions-for-small-byte-a.patch application/octet-stream 2.9 KB
v32-0003-Add-radixtree-template.patch application/octet-stream 117.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-04-17 15:22:01 pgsql: Further cleanup of autoconf output files for GSSAPI changes.
Previous Message Tom Lane 2023-04-17 15:16:30 Re: v16dev: TRAP: failed Assert("size > SizeOfXLogRecord"), File: "xlog.c", Line: 1055, PID: 13564