Re: GUC for cleanup indexes threshold.

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Subject: Re: GUC for cleanup indexes threshold.
Date: 2017-02-15 08:07:35
Message-ID: CAD21AoCY9vTh4R+vcF4ccRq5gx=xHMZDQe7H=O2s8_OziGOTrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 15, 2017 at 4:39 PM, Ideriha, Takeshi
<ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com> wrote:
> Hi, I tried regression test and found some errors concerning brin and gin,
> though I didn't look into this.
>
> Here's a log:
>
> *** /home/ideriha/postgres-master/src/test/regress/expected/brin.out 2017-02-13 11:33:43.270942937 +0900
> --- /home/ideriha/postgres-master/src/test/regress/results/brin.out 2017-02-15 14:58:24.725984474 +0900
> ***************
> *** 403,408 ****
> SELECT brin_summarize_new_values('brinidx'); -- ok, no change expected
> brin_summarize_new_values
> ---------------------------
> ! 0
> (1 row)
>
> --- 403,408 ----
> SELECT brin_summarize_new_values('brinidx'); -- ok, no change expected
> brin_summarize_new_values
> ---------------------------
> ! 5
> (1 row)
>
>
> ======================================================================
>
> *** /home/ideriha/postgres-master/src/test/regress/expected/gin.out 2016-12-20 16:49:09.513050050 +0900
> --- /home/ideriha/postgres-master/src/test/regress/results/gin.out 2017-02-15 14:58:25.536984461 +0900
> ***************
> *** 20,26 ****
> select gin_clean_pending_list('gin_test_idx'); -- nothing to flush
> gin_clean_pending_list
> ------------------------
> ! 0
> (1 row)
>
> -- Test vacuuming
> --- 20,26 ----
> select gin_clean_pending_list('gin_test_idx'); -- nothing to flush
> gin_clean_pending_list
> ------------------------
> ! 8
> (1 row)
>
> -- Test vacuuming
>
> ======================================================================
>
>

Thank you for testing!

It's a bug. Attached latest version patch, which passed make check.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
skip_cleanup_indexdes_v2.patch application/octet-stream 3.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-02-15 08:32:49 Re: Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags
Previous Message Seki, Eiji 2017-02-15 07:55:23 Re: Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags