| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2021-10-21 04:59:17 |
| Message-ID: | CAD21AoCTtQgfy57AxB4q8KUOpRH8rkHN=s_9p9Pvno_XoBK5wg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 20, 2021 at 12:33 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Mon, Oct 18, 2021 at 12:34 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I've attached updated patches that incorporate all comments I got so far.
> >
>
> Minor comment on patch 17-0003
Thank you for the comment!
>
> src/backend/replication/logical/worker.c
>
> (1) Typo in apply_handle_stream_abort() comment:
>
> /* Stop skipping transaction transaction, if enabled */
> should be:
> /* Stop skipping transaction changes, if enabled */
Fixed.
I've attached updated patches. In this version, in addition to the
review comments I go so far, I've changed the view name from
pg_stat_subscription_errors to pg_stat_subscription_workers as per the
discussion on including xact info to the view on another thread[1].
I’ve also changed related codes accordingly.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v18-0003-Add-skip_xid-option-to-ALTER-SUBSCRIPTION.patch | application/octet-stream | 31.3 KB |
| v18-0002-Add-RESET-command-to-ALTER-SUBSCRIPTION-command.patch | application/octet-stream | 12.9 KB |
| v18-0001-Add-a-subscription-worker-statistics-view-pg_sta.patch | application/octet-stream | 52.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-10-21 05:21:17 | Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds? |
| Previous Message | Sasasu | 2021-10-21 04:18:59 | Re: XTS cipher mode for cluster file encryption |