Re: pgbench: Skipping the creating primary keys after initialization

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench: Skipping the creating primary keys after initialization
Date: 2017-09-19 01:44:55
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

On Fri, Sep 8, 2017 at 9:52 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Thu, Sep 7, 2017 at 4:15 PM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>>>> Very very minor comments that I should have noticed before, sorry for
>>>> this
>>>> additional round trip.
>>> Thank you for the dedicated review!
>> I'm someone at times pigheaded, I think in the good sense if it is possible,
>> and I like to finish what I start:-)
>> Patch applies, compiles, works, everything is fine from my point of view.
>> I switched it to "Ready for Committer".
> Thanks.
>> Again, if the pgbench tap test patch get through, it should be tap tested.
> Thank you for the remainder, I'll add tap tests once the patch got committed.

Attached the latest version patch incorporated the tap tests.
Please review it.

Masahiko Sawada
NTT Open Source Software Center

Attachment Content-Type Size
pgbench_custom_initialization_v13.patch application/octet-stream 17.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2017-09-19 01:47:40 Re: SERIALIZABLE with parallel query
Previous Message Thomas Munro 2017-09-19 01:42:19 Re: SERIALIZABLE with parallel query