Tab-comletion for RLS

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Tab-comletion for RLS
Date: 2015-12-08 13:32:31
Message-ID: CAD21AoAz4SQMK-E=VVoMViMa=btABNXY==d0fv38zGPRB98AMQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hi all,


I found some lacks of tab-completion for RLS in 9.5.

* ALTER POLICY [TAB]
I expected to appear the list of policy name, but nothing is appeared.

* ALTER POLICY hoge_policy ON [TAB]
I expected to appear the list of table name related to specified policy,
but all table names are appeared.

* ALTER POLICY ... ON ... TO [TAB]
I expected to appear { role_name | PUBLIC | CURRENT_USER | SESSION_USER },
but only role_name and PUBLIC are appeared.
Same problem is exists in

"
CREATE POLICY ... ON ... TO [TAB]

"

.

#1 and #2 problems are exist in 9.5 or later, but #3 is exist in only 9.5
because it's unintentionally fixed by
2f8880704a697312d8d10ab3a2ad7ffe4b5e3dfd commit.
I think we should apply the necessary part of this commit for 9.5 as well,
though?

Attached patches are:​
* 000_fix_tab_completion_rls.patch
fixes #1, #2 problem, and is for master branch and REL9_5_STABLE.​
* 001_fix_tab_completion_rls_for_95.patch
fixes #3 problem, and is for only REL9_5_STABLE.

​Regards,​

--
Masahiko Sawada

Attachment Content-Type Size
000_fix_tab_completion_rls.patch application/octet-stream 1.1 KB
001_fix_tab_completion_rls_for_95.patch application/octet-stream 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2015-12-08 13:42:58 Re: [PROPOSAL] Backup and recovery of pg_statistic
Previous Message Andres Freund 2015-12-08 13:09:54 Re: Error with index on unlogged table