|From:||Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>|
|Cc:||Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Vinayak Pokale <vinpokale(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>|
|Subject:||Re: Transactions involving multiple postgres foreign servers|
|Views:||Raw Message | Whole Thread | Download mbox|
On Tue, Mar 7, 2017 at 5:04 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Fri, Mar 3, 2017 at 1:24 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> On Thu, Mar 2, 2017 at 11:56 AM, vinayak
>> <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>> On 2017/02/28 16:54, Masahiko Sawada wrote:
>>> I've created a wiki page describing about the design and
>>> functionality of this feature. Also it has some examples of use case,
>>> so this page would be helpful for even testing. Please refer it if
>>> you're interested in testing this feature.
>>>  2PC on FDW
>>> Thank you for creating the wiki page.
>> Thank you for looking at this patch.
>>> In the "src/test/regress/pg_regress.c" file
>>> - * xacts. (Note: to reduce the probability of unexpected
>>> - * failures, don't set max_prepared_transactions any higher
>>> - * actually needed by the prepared_xacts regression test.)
>>> + * xacts. We also set max_fdw_transctions to enable testing
>>> of atomic
>>> + * foreign transactions. (Note: to reduce the probability of
>>> + * shmmax failures, don't set max_prepared_transactions or
>>> + * max_prepared_foreign_transactions any higher than
>>> actually needed by the
>>> + * corresponding regression tests.).
>>> I think we are not setting the "max_fdw_transctions" anywhere.
>>> Is this correct?
>> This comment is out of date. Will fix.
>>> In the "src/bin/pg_waldump/rmgrdesc.c" file following header file used two
>>> + #include "access/fdw_xact.h"
>>> I think we need to remove one line.
>> Not necessary. Will get rid of it.
>> Since these are not feature bugs I will incorporate these when making
>> update version patches.
> Attached updated set of patches.
> The differences from previous patch are,
> * Fixed a few bugs.
> * Separated previous 000 patch into two patches.
> * Changed name pg_fdw_xact_resovler contrib module to
> * Incorporated review comments got from Vinayak
> Please review these patches.
Since previous v9 patches conflict with current HEAD, I attached latest patches.
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
|Next Message||David Rowley||2017-03-13 01:19:05||Re: BRIN cost estimate|
|Previous Message||Vaishnavi Prabakaran||2017-03-13 00:54:02||Re: PATCH: Batch/pipelining support for libpq|