| From: | Paul Ramsey <pramsey(at)cleverelephant(dot)ca> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] postgres_fdw extension support |
| Date: | 2015-07-21 21:06:39 |
| Message-ID: | CACowWR3MkLo1xCMNPU_qrPh5FJxTOL=-MZSfoP5+Wkd0-bkgEw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 21, 2015 at 11:29 AM, Paul Ramsey <pramsey(at)cleverelephant(dot)ca> wrote:
> On July 21, 2015 at 11:22:12 AM, Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>
> No, *not* populated first-time-through, because that won't handle any of
> the CREATE, DROP, or UPGRADE cases. It's also doing a lot of work you
> might never need. I was thinking of "populate on demand", that is, first
> time you need to know whether function X is shippable, you find that out
> and then cache the answer (whether it be positive or negative).
>
>
> Roger that. Off to the races..
Attached, reworked with a local cache. I felt a little dirty sticking
the cache entry right in postgres_fdw.c, so I broke out all my
nonsense into shippable.c.
Thanks!
P
| Attachment | Content-Type | Size |
|---|---|---|
| fdw-extension-support4.diff | text/plain | 15.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gavin Flower | 2015-07-21 21:20:51 | Re: Alpha2/Beta1 |
| Previous Message | Josh Berkus | 2015-07-21 21:01:57 | Alpha2/Beta1 |