Re: [PATCH] postgres_fdw extension support

From: Paul Ramsey <pramsey(at)cleverelephant(dot)ca>
To: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: [PATCH] postgres_fdw extension support
Date: 2015-07-23 14:48:49
Message-ID: CACowWR2KiXoNGJ7aCZHzVdTysT5avcVy_RD0NU8QFzBm9QhdjQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 22, 2015 at 12:19 PM, Paul Ramsey <pramsey(at)cleverelephant(dot)ca> wrote:
>
> I’ll have a look at doing invalidation for the case of changes to the FDW
> wrappers and servers.

Here's an updated patch that clears the cache on changes to foreign
wrappers and servers.
In testing it I came across an unrelated issue which could make it
hard for users to manage the options on their wrappers/servers

fdw=# ALTER SERVER foreign_server OPTIONS ( extensions 'postgis' );
ALTER SERVER
fdw=# ALTER SERVER foreign_server OPTIONS ( extensions 'postgis,seg' );
ERROR: option "extensions" provided more than once

Once set, an option seems to be effectively immutable.

Attachment Content-Type Size
fdw-extension-support5.diff text/plain 16.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-07-23 14:57:09 Re: fdw_scan_tlist for foreign table scans breaks EPQ testing, doesn't it?
Previous Message Michael Paquier 2015-07-23 14:19:42 Re: ALTER TABLE .. ADD PRIMARY KEY .. USING INDEX has dump-restore hazard