Re: [PATCH] postgres_fdw extension support

From: Paul Ramsey <pramsey(at)cleverelephant(dot)ca>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] postgres_fdw extension support
Date: 2015-07-21 14:28:22
Message-ID: CACowWR1wiEbbtY54wV4gnzNQi+BXB=Y8A7RiveFLAbzeaOrFJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here's a third revision that allows the 'extensions' option on the
wrapper as well, so that supported extensions can be declared once in
one place.

Since the "CREATE FOREIGN DATA WRAPPER" statement is actually called
inside the "CREATE EXTENSION" script for postgres_fdw, the way to get
this option is actually to alter the wrapper,

ALTER FOREIGN DATA WRAPPER postgres_fdw OPTIONS ( extensions 'seg' );

Right now declaring extensions at different levels is additive, I
didn't add the option to revoke an extension for a particular server
definition (the "cube,-postgis" entry for example). If that's a
deal-breaker, I can add it too, but it felt like something that could
wait for a user to positively declare "I must have that feature!"

P.

On Fri, Jul 17, 2015 at 5:58 AM, Paul Ramsey <pramsey(at)cleverelephant(dot)ca> wrote:
>
> On July 17, 2015 at 5:57:42 AM, Simon Riggs (simon(at)2ndquadrant(dot)com(mailto:simon(at)2ndquadrant(dot)com)) wrote:
>
>> Options already exist on CREATE FOREIGN DATA WRAPPER, so it should be easy to support that.
>>
>> I'd rather add it once on the wrapper than be forced to list all the options on every foreign server, unless required to do so.
>
> Gotcha, that does make sense.
>
> P.

Attachment Content-Type Size
fdw-extension-support3.diff text/plain 12.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2015-07-21 14:42:52 Re: pgbench stats per script & other stuff
Previous Message Robert Haas 2015-07-21 14:24:01 Re: pgbench stats per script & other stuff