Re: [REVIEW] Tab Completion for CREATE DATABASE ... TEMPLATE ...

From: Kevin Grittner <kgrittn(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>, Sehrope Sarkuni <sehrope(at)jackdb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [REVIEW] Tab Completion for CREATE DATABASE ... TEMPLATE ...
Date: 2016-09-12 14:32:42
Message-ID: CACjxUsNXtgB4Zxbz7i-+PLpcJqGtGmjsOcZ17rUvB1C4xprGrA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Mon, Sep 12, 2016 at 8:14 AM, Kevin Grittner <kgrittn(at)gmail(dot)com> wrote:
> On Mon, Sep 12, 2016 at 7:55 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

>> The query you committed is flat wrong, because it doesn't
>> account for database ownership being granted via role membership.
>
> Ah, there was a flaw in my testing script. It appeared from my
> (flawed) testing that the inherited ownership wasn't enough to
> allow use as a template. With the script fixed I see that it does.
>
> Sorry for the noise. Will fix.

Done.

Thanks guys!

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2016-09-12 15:02:53 Re: Tuplesort merge pre-reading
Previous Message Tom Lane 2016-09-12 14:19:14 Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)