| From: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Marco Slot <marco(dot)slot(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Date: | 2023-03-10 14:28:33 |
| Message-ID: | CACawEhWd-BSpcGHKPjt3zVsGaRwP2+XuJoPPCDaGHM6XL8AqYg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Amit, all
> I'll look for more opportunities and reply to the thread. I wanted to send
> this mail so that you can have a look at (1) earlier.
>
>
> I merged SUBSCRIPTION CREATE/DROP INDEX WORKS WITHOUT ISSUES
into SUBSCRIPTION CAN USE INDEXES WITH EXPRESSIONS AND COLUMNS.
Also, merged SUBSCRIPTION USES INDEX WITH PUB/SUB DIFFERENT DATA and
A UNIQUE INDEX THAT IS NOT PRIMARY KEY OR REPLICA IDENTITY
So, we have 6 test cases left. I start to feel that trying to merge further
is going to start making
the readability get worse. Do you have any further easy test case merge
suggestions?
I think one option could be to drop some cases altogether, but not sure
we'd want that.
As a semi-related question: Are you aware of any setting that'd
make pg_stat_all_indexes
reflect the changes sooner? It is hard to debug what is the bottleneck in
the tests, but
I have a suspicion that there might be several poll_query_until() calls on
pg_stat_all_indexes, which might be the reason?
Attaching v43.
| Attachment | Content-Type | Size |
|---|---|---|
| v43_0002_use_index_on_subs_when_pub_rep_ident_full.patch | application/octet-stream | 50.4 KB |
| v43_0001_Skip-dropped_columns_for_tuples_equal.patch | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2023-03-10 14:30:04 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | Jim Jones | 2023-03-10 13:30:07 | Re: [PATCH] Add pretty-printed XML output option |