Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

>
>
>
> Thanks for the updated patch.
> Few minor comments:
> 1) The extra line break after IsIndexOnlyOnExpression function can be
> removed:
>

removed

>
>
> 2) Generally we don't terminate with "." for single line comments
> +
> + /*
> + * Simple case, we already have a primary key or a replica identity index.
> + */
> + idxoid = GetRelationIdentityOrPK(localrel);
> + if (OidIsValid(idxoid))
> + return idxoid;
>
> Well, there are several "." for single line comments even in the same
file such as:

/* 0 means it's a dropped attribute. See comments atop AttrMap. */

I really don't have any preference on this, but I doubt if I change it,
I'll get
another review suggesting to conform to the existing style in the same file.
So, I'm skipping this suggestion for now, unless you have objections.