| From: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Marco Slot <marco(dot)slot(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Date: | 2023-03-14 09:06:31 |
| Message-ID: | CACawEhV0ZOJJSWOdmNd0Oh3Z4KQc90hfn8eX3R+_CHt-2aVi-g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, 14 Mar 2023 Sal, 11:59 tarihinde
şunu yazdı:
> On Tue, Mar 14, 2023 at 12:48 PM Önder Kalacı <onderkalaci(at)gmail(dot)com>
> wrote:
> >>
> >> 2.
> >> +# make sure that the subscriber has the correct data after the update
> UPDATE
> >>
> >> "update UPDATE" seems to be a typo.
> >>
> >
> > thanks, fixed
> >
> >>
> >> 3.
> >> +# now, drop the index with the expression, and re-create index on
> column lastname
> >>
> >> The comment says "re-create index on column lastname" but it seems we
> didn't do
> >> that, should it be modified to something like:
> >> # now, drop the index with the expression, we will use sequential scan
> >>
> >>
> >
> > Thanks, fixed
> >
> > I'll add the changes to v49 in the next e-mail.
> >
>
> It seems you forgot to address these last two comments in the latest
> version.
>
>
Oops, sorry. I think when I get your test changes, I somehow overridden
these changes
on my local.
| Attachment | Content-Type | Size |
|---|---|---|
| v50_0001_use_index_on_subs_when_pub_rep_ident_full.patch | application/octet-stream | 44.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2023-03-14 09:14:16 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Previous Message | Amit Kapila | 2023-03-14 08:59:38 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |