Re: Speedup usages of pg_*toa() functions

From: John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Speedup usages of pg_*toa() functions
Date: 2020-07-02 03:57:47
Message-ID: CACPNZCt+R_VhawHd2-KoDtv=4uVOapzs4x=xXPORouQyvdjgsg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 13, 2020 at 8:36 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I ended up chickening out of doing the larger allocation
> unconditionally. Instead, I pushed the original idea of doing the
> palloc/memcpy of the length returned by pg_lltoa. That gets us most
> of the gains without the change in memory usage behaviour.

This was still marked as needing review in commitfest, so I marked it
as committed.

--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-07-02 04:53:30 Re: Remove page-read callback from XLogReaderState.
Previous Message Amit Kapila 2020-07-02 03:37:10 Re: Backpatch b61d161c14 (Introduce vacuum errcontext ...)